Discipline...

As I type this my oldest dd is in time out and not very happy about it! So when you were a child and needed punishment, which parent punished you and how? How do you punish your children? Does it work? Really any comments you want to leave here would be great with me - apparently what I am doing isn't working!